sjvanrossum commented on PR #32962: URL: https://github.com/apache/beam/pull/32962#issuecomment-2490816511
@bzablocki I think this can be simplified by storing the message handles for the last emitted checkpoint mark in the reader and having both the reader and the checkpoint mark attempt to acknowledge those messages. The reader would attempt to do this at some point in `advance` (preferably by submitting a cleanup task to a background thread) and lastly in `close` before closing the reader. The checkpoint mark remains unmodified and would attempt to acknowledge messages in `finalize` as it does today. Have a look at my comment about simplifying the safe-to-ack exchange between the reader and the checkpoint mark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
