sjvanrossum commented on code in PR #32962:
URL: https://github.com/apache/beam/pull/32962#discussion_r1852334054
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java:
##########
@@ -119,8 +116,9 @@ public MessageReceiver getReceiver() {
this.messageReceiver =
retryCallableManager.retryCallable(
this::createFlowReceiver, ImmutableSet.of(JCSMPException.class));
+ this.messageReceiver.start();
}
- return this.messageReceiver;
+ return checkStateNotNull(this.messageReceiver);
Review Comment:
This check should not be necessary. Either `this.messageReceiver` was
non-null or the body of the if statement ensures `this.messageReceiver` is
non-null when the method returns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
