bzablocki commented on PR #32962: URL: https://github.com/apache/beam/pull/32962#issuecomment-2505810684
Thank you @ppawel for testing, great to hear it's looking good! Would you say it's ready to merge? >seems strange that there are messages in the queue (see above point 1) when this new pipeline starts but for some reason the connections to Solace need to be reestablished after 1 minute of idle time for it to start consuming. If it's only at the startup then it is probably because it takes some time for from creating an UnboundedSolaceReader (when a client is created for the first time) to the client being actually used. If it takes more than 1 minute ([hard-coded max idle time](https://github.com/apache/beam/pull/32962/files#diff-78368f3ed083566de0c19c7a67aacf60f73caa1ddb2b5015e7522ef413304860R82)), it will be closed, removed and recreated when needed. I think this is acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
