arunpandianp commented on code in PR #33512:
URL: https://github.com/apache/beam/pull/33512#discussion_r1905391794
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarnessTest.java:
##########
@@ -242,7 +242,7 @@ public void testStreamsStartCorrectly() throws
InterruptedException {
@Test
public void testOnNewWorkerMetadata_correctlyRemovesStaleWindmillServers()
throws InterruptedException {
- TestGetWorkBudgetDistributor getWorkBudgetDistributor = spy(new
TestGetWorkBudgetDistributor());
+ GetWorkBudgetDistributor getWorkBudgetDistributor =
mock(GetWorkBudgetDistributor.class);
Review Comment:
Without this change the test is deadlocking with this threadz
https://gist.github.com/arunpandianp/c084d7389fe93202a8d9d7ba27e8ca50
Not sure what triggered it, this PR shouldn't change anything wrt locking.
Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
