scwhittle commented on code in PR #33512:
URL: https://github.com/apache/beam/pull/33512#discussion_r1910232443
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -789,7 +789,7 @@ private static GrpcWindmillStreamFactory.Builder
createGrpcwindmillStreamFactory
!options.isEnableStreamingEngine()
|| DataflowRunner.hasExperiment(
options,
"streaming_engine_disable_new_heartbeat_requests"))
-
.setMultipleItemsInGetWorkResponse(options.getWindmillMultipleItemsInGetWorkResponse());
+
.setBatchedGetWorkResponse(options.getWindmillRequestBatchedGetWorkResponse());
Review Comment:
can this be setRequestBatchedGetWorkResponse
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetWorkStream.java:
##########
@@ -45,13 +45,19 @@ final class GrpcGetWorkStream
implements GetWorkStream {
private static final Logger LOG =
LoggerFactory.getLogger(GrpcGetWorkStream.class);
+ private static final StreamingGetWorkRequest HEALTH_CHECK =
+ StreamingGetWorkRequest.newBuilder()
+ .setRequestExtension(
+
StreamingGetWorkRequestExtension.newBuilder().setMaxItems(0).setMaxBytes(0).build())
+ .build();
private final GetWorkRequest request;
private final WorkItemReceiver receiver;
private final ThrottleTimer getWorkThrottleTimer;
private final Map<Long, GetWorkResponseChunkAssembler> workItemAssemblers;
private final AtomicLong inflightMessages;
private final AtomicLong inflightBytes;
+ private final boolean batchedGetWorkResponse;
Review Comment:
requestBatchedGetWorkResponse
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -80,7 +89,7 @@ final class GrpcDirectGetWorkStream
*/
private final ConcurrentMap<Long, GetWorkResponseChunkAssembler>
workItemAssemblers;
- private final boolean multipleItemsInGetWorkResponse;
+ private final boolean batchedGetWorkResponse;
Review Comment:
this too, I think it is easier to understand what it is. otherwise the name
sounds like it is a response to me
ditto for the other files
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -140,6 +145,7 @@ static GrpcDirectGetWorkStream create(
StreamObserverFactory streamObserverFactory,
Set<AbstractWindmillStream<?, ?>> streamRegistry,
int logEveryNStreamFailures,
+ boolean multipleItemsInGetWorkResponse,
Review Comment:
name is inconsistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
