arunpandianp commented on code in PR #33512:
URL: https://github.com/apache/beam/pull/33512#discussion_r1910206184
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -184,6 +182,7 @@ private void maybeSendRequestExtension(GetWorkBudget
extension) {
Windmill.StreamingGetWorkRequestExtension.newBuilder()
.setMaxItems(extension.items())
.setMaxBytes(extension.bytes()))
+
.setSupportsMultipleWorkItemsInChunk(multipleItemsInGetWorkResponse)
Review Comment:
Removed.
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -231,7 +231,15 @@ public void appendSpecificHtml(PrintWriter writer) {
@Override
public void sendHealthCheck() throws WindmillStreamShutdownException {
- trySend(HEALTH_CHECK_REQUEST);
+ trySend(
+ StreamingGetWorkRequest.newBuilder()
+ .setRequestExtension(
+ Windmill.StreamingGetWorkRequestExtension.newBuilder()
+ .setMaxItems(0)
+ .setMaxBytes(0)
+ .build())
+
.setSupportsMultipleWorkItemsInChunk(multipleItemsInGetWorkResponse)
Review Comment:
Done
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStreamTest.java:
##########
@@ -161,7 +161,7 @@ private Windmill.StreamingGetWorkResponseChunk
createResponse(Windmill.WorkItem
.setInputDataWatermark(1L)
.setDependentRealtimeInputWatermark(1L)
.build())
- .setSerializedWorkItem(workItem.toByteString())
+ .addSerializedWorkItem(workItem.toByteString())
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
