clairemcginty commented on PR #33368: URL: https://github.com/apache/beam/pull/33368#issuecomment-2582927125
> > looks like it is coded in test to prevent the exposure of unwanted classes. Refactor in a way that does not leak these may fix > > hmm, this seems challenging to refactor since the exposure is coming from `interface com.google.cloud.hadoop.gcsio.GoogleCloudStorage` itself... and there's no superclass/subclass that would be appropriate to substitute in here. I guess instead of adding a provider for a `GoogleCloudStorage` instance, we could add a provider for a `BiFunction<StorageResourceId, CreateObjectOptions, WritableByteChannel>` ? Although that would leak more implementation details to the user. hey @Abacn ! just wanted to ping this thread before the PR goes stale :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
