Abacn commented on code in PR #33368:
URL: https://github.com/apache/beam/pull/33368#discussion_r1911109001
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java:
##########
@@ -739,7 +741,42 @@ public WritableByteChannel create(GcsPath path,
CreateOptions options) throws IO
GoogleCloudStorage createGoogleCloudStorage(
GoogleCloudStorageOptions options, Storage storage, Credentials
credentials) {
- return new GoogleCloudStorageImpl(options, storage, credentials);
+ try {
+ // Attempt to construct gcs-connector 3.x-style GoogleCloudStorage,
which is created
+ // exclusively via Builder method; this can be replaced once Java 8 is
dropped and
Review Comment:
could add a // TODO tag like
// TODO eliminate reflection once Beam drops Java 8 support and upgrade to
use gcsio 3.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
