Abacn commented on PR #33368:
URL: https://github.com/apache/beam/pull/33368#issuecomment-2588278435
Sorry for another late request
I've been a little bit worry about relying on the `try {} catch {}` to
determine the code path, which happened to bring out performance regression in
#33575
since using Reflection is already a hack, I do not see a good solution to
this either. But could we try {return new GoogleCloudStorageImpl(...)} first?
So in the default dependency versions (gcs 2.x), it won't throw Exception (even
though it is handled) after this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
