tomstepp commented on PR #33596:
URL: https://github.com/apache/beam/pull/33596#issuecomment-2622649910
> I think you need to set a default value for this change to be compatible.
May be it just passed randomly due to the retry ?
When setting a default value and marking offset dedup as only compatible
with legacy, Kafka read jobs with SDF-only arguments will fail saying there is
no possible implementation (legacy/unbounded or SDF).
Example from `testReadTransformCreationWithSdfImplementationBoundProperty`:
```
There is no Kafka read implementation that supports every configured
property! Not supported implementations with the associated properties:
{SDF=[OFFSET_DEDUPLICATION], LEGACY=[STOP_READ_TIME]}
```
@chamikaramj I don't think we need to specify a non-null default. Am I
misunderstanding something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
