tomstepp commented on code in PR #33596:
URL: https://github.com/apache/beam/pull/33596#discussion_r1936630662
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1776,6 +1810,9 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
if (kafkaRead.getRedistributeNumKeys() > 0) {
readTransform =
readTransform.withRedistributeNumKeys(kafkaRead.getRedistributeNumKeys());
}
+ // if (kafkaRead.getOffsetDeduplication() != null) {
Review Comment:
Done, sorry I missed that!
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -2221,6 +2258,9 @@ public abstract static class ReadSourceDescriptors<K, V>
@Pure
abstract int getRedistributeNumKeys();
+ // @Pure
+ // abstract @Nullable Boolean getOffsetDeduplication();
Review Comment:
Done, sorry I missed that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
