tomstepp commented on code in PR #33596:
URL: https://github.com/apache/beam/pull/33596#discussion_r1938692363
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIOReadImplementationCompatibility.java:
##########
@@ -137,6 +137,7 @@ Object getDefaultValue() {
return false;
}
},
+ OFFSET_DEDUPLICATION(LEGACY),
Review Comment:
It confused me at first as well, previously I had only worked with simple
enums. In Java, enums can have constructors, methods, etc., like classes. This
enum has a few methods below with the closing brace at L179 at head, L180 on
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
