shunping commented on code in PR #33611:
URL: https://github.com/apache/beam/pull/33611#discussion_r1939532252
##########
sdks/python/apache_beam/io/gcp/gcsfilesystem.py:
##########
@@ -354,7 +354,7 @@ def delete(self, paths):
for path in paths:
if path.endswith('/'):
- path_to_use = path + '*'
+ return self._gcsIO().delete(path, recursive=True)
Review Comment:
I think we should not return here, because it might lead to an early stop of
the path loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
