mohamedawnallah commented on PR #33611: URL: https://github.com/apache/beam/pull/33611#issuecomment-2631376087
Hi @shunping, Thanks for your follow-up review! I've addressed your feedback. This might be unrelated, but I’d like to use this PR as an opportunity to learn more about Beam development practices as I am getting used to it. My interest was sparked by this discussion: https://github.com/apache/beam/pull/33672#issuecomment-2630967193. When addressing a review and make a follow-up commit to fix the issues, Someone should avoid squashing reviewed and unreviewed commits. After the follow-up review is completed, would it be necessary to squash the follow-up commit (I am thinking about delay in the merging process e.g for the CI to be triggered again), or is it acceptable to leave the follow-up commit as part of the commit history? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
