shunping commented on code in PR #33611:
URL: https://github.com/apache/beam/pull/33611#discussion_r1939542772
##########
sdks/python/apache_beam/io/gcp/gcsfilesystem.py:
##########
@@ -354,7 +354,7 @@ def delete(self, paths):
for path in paths:
if path.endswith('/'):
- path_to_use = path + '*'
+ return self._gcsIO().delete(path, recursive=True)
Review Comment:
Actually, that was my mistake when i suggested the code change at
https://github.com/apache/beam/pull/33611#discussion_r1937608203.
I think we will need to continue the loop in case users are calling this api
to delete multiple directories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
