scwhittle commented on code in PR #34214:
URL: https://github.com/apache/beam/pull/34214#discussion_r1990169538
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/common/worker/MapTaskExecutorTest.java:
##########
@@ -328,7 +329,7 @@ public void start() throws Exception {
}
}
});
-
+ sampler.start();
Review Comment:
seems like the getMillisSinceBundleStart check = 0 below could be flaky if
this is running?
What was the error from before? I'm not seeing how the change could have
made something fail due to the change if the value compared is initialized with
the desired value as well:
private long nextBundleLullDurationReportMs = BUNDLE_LULL_REPORT_MS;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
