scwhittle commented on code in PR #34214:
URL: https://github.com/apache/beam/pull/34214#discussion_r1995472660
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/common/worker/MapTaskExecutorTest.java:
##########
@@ -328,7 +329,7 @@ public void start() throws Exception {
}
}
});
-
+ sampler.start();
Review Comment:
what about moving the statetracker checks before the try block?
Then we're verifying the initial state but it won't be racy whether the
bundle had progress or not yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
