Abacn commented on code in PR #34214:
URL: https://github.com/apache/beam/pull/34214#discussion_r1991617045
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/common/worker/MapTaskExecutorTest.java:
##########
@@ -328,7 +329,7 @@ public void start() throws Exception {
}
}
});
-
+ sampler.start();
Review Comment:
The error before was "java.lang.AssertionError: expected:<600000> but
was:<1200000> at
org.apache.beam.runners.dataflow.worker.util.common.worker.MapTaskExecutorTest.testGetMetricContainers(MapTaskExecutorTest.java:346)"
(https://github.com/apache/beam/runs/38521160076)
It is because removeTracker on clean up would sample once more:
https://github.com/apache/beam/blob/a69094861cbb4ad49f83d37def7bcef771e64c0a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateSampler.java#L167
and due to ExecutionStateSampler.lastSampleTimeMillis is zero,
millisSinceLastSample is very large and triggered
https://github.com/apache/beam/blob/a69094861cbb4ad49f83d37def7bcef771e64c0a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateTracker.java#L385
because reset nextLullReportMs is moved out of deactivate, at the end of the
call nextLullReportMs becames 20 min.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
