damccorm commented on code in PR #34320:
URL: https://github.com/apache/beam/pull/34320#discussion_r1998685460
##########
sdks/java/io/kafka/build.gradle:
##########
@@ -71,7 +71,10 @@ dependencies {
implementation library.java.joda_time
implementation library.java.jackson_annotations
implementation library.java.jackson_databind
- implementation group: 'com.google.cloud.hosted.kafka', name:
'managed-kafka-auth-login-handler', version: '1.0.5'
+ implementation (group: 'com.google.cloud.hosted.kafka', name:
'managed-kafka-auth-login-handler', version: '1.0.5') {
+ // "kafka-clients" has to be provided since user can use its own version.
+ exclude group: 'org.apache.kafka', module: 'kafka-clients'
Review Comment:
Hm, interesting - is the idea that https://github.com/apache/beam/pull/34197
broke this? cc/ @fozzie15 @Abacn
That makes sense given the error/timing -
https://github.com/apache/beam/actions/workflows/beam_PreCommit_SQL.yml?query=branch%3Amaster+event%3Aschedule
- but is kinda surprising.
```
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':sdks:java:extensions:sql:shell:startScripts'.
> Error while evaluating property 'relativeClasspath' of task
':sdks:java:extensions:sql:shell:startScripts'.
> Could not resolve all files for configuration
':sdks:java:extensions:sql:shell:runtimeClasspath'.
> Could not find org.apache.kafka:kafka-clients:7.6.1-ccs.
Searched in the following locations:
-
file:/runner/_work/beam/beam/sdks/java/extensions/sql/shell/offline-repository/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://repo.maven.apache.org/maven2/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
file:/home/runner/.m2/repository/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://oss.sonatype.org/content/repositories/staging/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://repository.apache.org/content/repositories/releases/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
Required by:
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project
:sdks:java:io:kafka
> Could not find org.apache.kafka:kafka-clients:7.6.1-ccs.
Searched in the following locations:
-
file:/runner/_work/beam/beam/sdks/java/extensions/sql/shell/offline-repository/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://repo.maven.apache.org/maven2/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
file:/home/runner/.m2/repository/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://oss.sonatype.org/content/repositories/staging/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://repository.apache.org/content/repositories/releases/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
Required by:
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project
:sdks:java:io:kafka >
com.google.cloud.hosted.kafka:managed-kafka-auth-login-handler:1.0.5
> Could not find org.apache.kafka:kafka-clients:7.6.1-ccs.
Searched in the following locations:
-
file:/runner/_work/beam/beam/sdks/java/extensions/sql/shell/offline-repository/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://repo.maven.apache.org/maven2/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
file:/home/runner/.m2/repository/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://oss.sonatype.org/content/repositories/staging/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
-
https://repository.apache.org/content/repositories/releases/org/apache/kafka/kafka-clients/7.6.1-ccs/kafka-clients-7.6.1-ccs.pom
Required by:
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project
:sdks:java:io:kafka > io.confluent:kafka-schema-registry-client:7.6.1
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org./
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task
':sdks:java:extensions:sql:shell:analyzeClassesDependencies'.
> Could not resolve all files for configuration
':sdks:java:extensions:sql:shell:permitUnusedDeclared'.
> Could not find org.apache.kafka:kafka-clients:7.6.1-ccs.
Required by:
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project
:sdks:java:io:kafka
> Could not find org.apache.kafka:kafka-clients:7.6.1-ccs.
Required by:
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project
:sdks:java:io:kafka >
com.google.cloud.hosted.kafka:managed-kafka-auth-login-handler:1.0.5
> Could not find org.apache.kafka:kafka-clients:7.6.1-ccs.
Required by:
project :sdks:java:extensions:sql:shell > project
:sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project
:sdks:java:io:kafka > io.confluent:kafka-schema-registry-client:7.6.1
```
##########
sdks/java/io/kafka/build.gradle:
##########
@@ -71,7 +71,10 @@ dependencies {
implementation library.java.joda_time
implementation library.java.jackson_annotations
implementation library.java.jackson_databind
- implementation group: 'com.google.cloud.hosted.kafka', name:
'managed-kafka-auth-login-handler', version: '1.0.5'
+ implementation (group: 'com.google.cloud.hosted.kafka', name:
'managed-kafka-auth-login-handler', version: '1.0.5') {
Review Comment:
@fozzie15 could you review this? And could you follow up and add a test to
help us avoid breakages like this in the future (seems like a hard to predict
issue, but we could have a test where a user brings their own kafka library, or
we could just add this path to
https://github.com/apache/beam/blob/master/.github/workflows/beam_PreCommit_SQL.yml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
