kennknowles commented on code in PR #34320:
URL: https://github.com/apache/beam/pull/34320#discussion_r1999076498
##########
sdks/java/io/kafka/build.gradle:
##########
@@ -71,7 +71,10 @@ dependencies {
implementation library.java.joda_time
implementation library.java.jackson_annotations
implementation library.java.jackson_databind
- implementation group: 'com.google.cloud.hosted.kafka', name:
'managed-kafka-auth-login-handler', version: '1.0.5'
+ implementation (group: 'com.google.cloud.hosted.kafka', name:
'managed-kafka-auth-login-handler', version: '1.0.5') {
+ // "kafka-clients" has to be provided since user can use its own version.
+ exclude group: 'org.apache.kafka', module: 'kafka-clients'
Review Comment:
`./gradlew :sdks:java:io:kafka:dependencies` on `master` at time of this
comment pulls `org.apache.kafka:kafka-clients:2.4.1` which makes sense as that
is set at
https://github.com/apache/beam/blob/76b0df9205110e877c16d8e01013f29cc98400f2/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
