damccorm commented on code in PR #34320:
URL: https://github.com/apache/beam/pull/34320#discussion_r1999201940


##########
sdks/java/io/kafka/build.gradle:
##########
@@ -71,7 +71,10 @@ dependencies {
   implementation library.java.joda_time
   implementation library.java.jackson_annotations
   implementation library.java.jackson_databind
-  implementation group: 'com.google.cloud.hosted.kafka', name: 
'managed-kafka-auth-login-handler', version: '1.0.5'
+  implementation (group: 'com.google.cloud.hosted.kafka', name: 
'managed-kafka-auth-login-handler', version: '1.0.5') {
+    // "kafka-clients" has to be provided since user can use its own version.
+    exclude group: 'org.apache.kafka', module: 'kafka-clients'

Review Comment:
   I ran 
https://github.com/apache/beam/actions/runs/13904647221/job/38904626016 against 
a revert of the bom (https://github.com/apache/beam/pull/34325), and it 
similarly failed. I can't revert https://github.com/apache/beam/pull/34197 
because commits are layered on top, but it seems much more likely to have been 
the problem given it changed the dependency in this chain, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to