Abacn commented on code in PR #34394:
URL: https://github.com/apache/beam/pull/34394#discussion_r2010704388
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -72,6 +72,8 @@ public Schema configurationSchema() {
// readQuery
.addNullableField("partitionColumn", FieldType.STRING)
.addNullableField("partitions", FieldType.INT16)
+ .addNullableField("longLowerBound", FieldType.INT64)
Review Comment:
We can just support long for now, However this is public API surface and we
need to consider extendability. Saying we are going to support other
lower/upper bound types in the future, then every time a type added one needs
to add a new field to schemaio providers and touch multiple files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
