kennknowles commented on code in PR #34394:
URL: https://github.com/apache/beam/pull/34394#discussion_r2012738099
##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProviderTest.java:
##########
@@ -131,6 +131,31 @@ public void testPartitionedReadWithExplicitSchema() {
pipeline.run();
}
+ @Test
+ public void testPartitionedReadWithExplicitLongBounds() {
+ JdbcSchemaIOProvider provider = new JdbcSchemaIOProvider();
+
+ Row config =
+ Row.withSchema(provider.configurationSchema())
+ .withFieldValue("driverClassName",
DATA_SOURCE_CONFIGURATION.getDriverClassName().get())
+ .withFieldValue("jdbcUrl",
DATA_SOURCE_CONFIGURATION.getUrl().get())
+ .withFieldValue("username", "")
+ .withFieldValue("password", "")
+ .withFieldValue("partitionColumn", "id")
+ .withFieldValue("partitions", (short) 5)
+ .withFieldValue("longLowerBound", 0L)
Review Comment:
nit: leave the type out of the field name
These names are user-facing (unless we do work to hide them) in managed IO,
YAML, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
