damccorm commented on code in PR #34424: URL: https://github.com/apache/beam/pull/34424#discussion_r2014412836
########## sdks/python/apache_beam/internal/cloudpickle/__init__.py: ########## @@ -0,0 +1,18 @@ +from . import cloudpickle +from .cloudpickle import * # noqa Review Comment: Nit: to be explicit I think it might be good to put this in `.../apache_beam/internal/vendor/...` instead of `.../apache_beam/internal/...` ########## LICENCE.cloudpickle: ########## @@ -0,0 +1,29 @@ +Copyright (c) 2012-now, CloudPickle developers and contributors. Review Comment: I'm not sure how we've done this in the past, but I think it probably makes sense to colocate the license with the source. That will also ensure it actually gets packed into the Python container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
