tvalentyn commented on code in PR #34424: URL: https://github.com/apache/beam/pull/34424#discussion_r2014888910
########## LICENCE.cloudpickle: ########## @@ -0,0 +1,29 @@ +Copyright (c) 2012-now, CloudPickle developers and contributors. Review Comment: I checked what is included in containers images by searching `find . -name *LICENSE*`: Seeing: * `./opt/apache/beam/third_party_licenses/cloudpickle/LICENSE` -- this would probably disappear if cloudpickle is not a dependency, unless we modify sdks/python/container/license_scripts/manual_licenses to copy it, which may not be necessary if we add the license in one of the two below places: * `./opt/apache/beam/LICENSE` * `./opt/apache/beam/LICENSE.python` -- we could add `LICENSE.cloudpickle` as proposed in this PR I don't have preference which file to add it to, we can see what is simpler and easier to import internally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
