tvalentyn commented on code in PR #34424:
URL: https://github.com/apache/beam/pull/34424#discussion_r2017606168


##########
LICENCE.cloudpickle:
##########
@@ -0,0 +1,29 @@
+Copyright (c) 2012-now, CloudPickle developers and contributors.

Review Comment:
   > Does LICENSE.cloudpickle work for building containers?
   
   yes, it works, we can check that it is included in the container build. for 
example, by running smth like
   
   ```
   gradlew :sdks:python:container:py310:docker
   docker run --rm -it --entrypoint=/bin/bash 
apache/beam_python3.10_sdk:2.65.0.dev
   
   ```
   
   and inspecting the image content.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to