lostluck commented on code in PR #34348:
URL: https://github.com/apache/beam/pull/34348#discussion_r2021674193
##########
sdks/go/pkg/beam/runners/prism/internal/urns/urns.go:
##########
@@ -124,6 +124,7 @@ var (
CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER)
CoderKV = cdrUrn(pipepb.StandardCoders_KV)
+ CoderTuple = "beam:coder:tuple:v1"
Review Comment:
> Oh and of course big follow-up question: this coder is not new...
presumably it already works, so why does this change require it to become
runner-understood?
And specifically for this question: If it's not in the validates runner
suite it's extremely hard to test when one doesn't use the SDK. In this case,
there was exactly one test for it. There's only ~70 validates runner tests for
Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
