Abacn commented on code in PR #34542:
URL: https://github.com/apache/beam/pull/34542#discussion_r2028886361
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java:
##########
@@ -102,7 +102,7 @@ public static void encode(long v, OutputStream stream)
throws IOException {
/** Decodes an integer value from the given stream. */
public static int decodeInt(InputStream stream) throws IOException {
long r = decodeLong(stream);
- if (r < 0 || r >= 1L << 32) {
Review Comment:
This is a valid check. when encoding int, there is a bit operation:
https://github.com/apache/beam/blob/c59ba993122414af645734f4e3518cdda25a7da4/sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java#L35
where negative int will become a positive long
please revert java side changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
