DKER2 commented on code in PR #34542:
URL: https://github.com/apache/beam/pull/34542#discussion_r2029827815
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java:
##########
@@ -102,7 +102,7 @@ public static void encode(long v, OutputStream stream)
throws IOException {
/** Decodes an integer value from the given stream. */
public static int decodeInt(InputStream stream) throws IOException {
long r = decodeLong(stream);
- if (r < 0 || r >= 1L << 32) {
Review Comment:
@Abacn Sorry, but I do not get it clear. Can I clarify that we should revert
back this change, is it what you mean? If it is the case, then we I believe we
still need https://github.com/apache/beam/pull/30770 as a work around to
convert -1 in python to positive value
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java:
##########
@@ -102,7 +102,7 @@ public static void encode(long v, OutputStream stream)
throws IOException {
/** Decodes an integer value from the given stream. */
public static int decodeInt(InputStream stream) throws IOException {
long r = decodeLong(stream);
- if (r < 0 || r >= 1L << 32) {
Review Comment:
@Abacn Sorry, but I do not get it clear. Can I clarify that we should revert
back this change, is it what you mean? If it is the case, then we I believe we
still need https://github.com/apache/beam/pull/30770 as a work around to
convert -1 in python to unsigned value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
