Abacn commented on code in PR #34542:
URL: https://github.com/apache/beam/pull/34542#discussion_r2028911859
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java:
##########
@@ -102,7 +102,7 @@ public static void encode(long v, OutputStream stream)
throws IOException {
/** Decodes an integer value from the given stream. */
public static int decodeInt(InputStream stream) throws IOException {
long r = decodeLong(stream);
- if (r < 0 || r >= 1L << 32) {
Review Comment:
I see, #30770 was a workaround due to wrong schema mapping between python
<-> java. The root cause should be resolved after #34354
Thought again I think it's no harm to loose the check in case there are
elsewhere INT32 and INT64 were used interchangeably.
Consider `(r < -1L << 31 || r >= 1L << 32) {` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
