lostluck commented on code in PR #34348:
URL: https://github.com/apache/beam/pull/34348#discussion_r2035992388
##########
sdks/go/pkg/beam/runners/prism/internal/urns/urns.go:
##########
@@ -124,6 +124,7 @@ var (
CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER)
CoderKV = cdrUrn(pipepb.StandardCoders_KV)
+ CoderTuple = "beam:coder:tuple:v1"
Review Comment:
To avoid issues like this, prism must not add handling for specific
nonstandard coders as much as possible.
As implemented there was only the leaf coders that needed special handling
for length prefixing, but now we need special handling for unknown composite
coders. Since it's different from how we want standard composites to behave.
One more note: KVs don't get length prefixed wrapped because it's important
to be able to extract the key or the value by themselves. But it also doesn't
serve prism to have multiple different ways of treating KVs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
