m-trieu commented on code in PR #34539:
URL: https://github.com/apache/beam/pull/34539#discussion_r2033785356
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/ChannelCache.java:
##########
@@ -107,6 +122,23 @@ public ManagedChannel get(WindmillServiceAddress
windmillServiceAddress) {
return channelCache.getUnchecked(windmillServiceAddress);
}
+ public synchronized void consumeFlowControlSettings(
+ UserWorkerGrpcFlowControlSettings flowControlSettings) {
+ if (!flowControlSettings.equals(currentFlowControlSettings)) {
Review Comment:
done, i also added a default flow control setting for directpath. equals in
java compares the fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
