m-trieu commented on code in PR #34539:
URL: https://github.com/apache/beam/pull/34539#discussion_r2033787096
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/WindmillChannelFactory.java:
##########
@@ -72,16 +78,22 @@ public static ManagedChannel remoteChannel(
private static ManagedChannel remoteDirectChannel(
AuthenticatedGcpServiceAddress authenticatedGcpServiceAddress,
- int windmillServiceRpcChannelTimeoutSec) {
- return withDefaultChannelOptions(
+ int windmillServiceRpcChannelTimeoutSec,
+ UserWorkerGrpcFlowControlSettings flowControlSettings) {
+ NettyChannelBuilder channelBuilder =
+ withDefaultChannelOptions(
NettyChannelBuilder.forAddress(
authenticatedGcpServiceAddress.gcpServiceAddress().getHost(),
// Ports are required for direct channels.
authenticatedGcpServiceAddress.gcpServiceAddress().getPort(),
new AltsChannelCredentials.Builder().build())
.overrideAuthority(authenticatedGcpServiceAddress.authenticatingService()),
- windmillServiceRpcChannelTimeoutSec)
- .build();
+ windmillServiceRpcChannelTimeoutSec);
+ int flowControlWindowSizeBytes =
+ Math.max(WINDMILL_MAX_FLOW_CONTROL_WINDOW,
flowControlSettings.getFlowControlWindowBytes());
Review Comment:
done
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/WindmillChannelFactory.java:
##########
@@ -122,8 +135,7 @@ private static NettyChannelBuilder
withDefaultChannelOptions(
.maxInboundMessageSize(Integer.MAX_VALUE)
.maxTraceEvents(MAX_REMOTE_TRACE_EVENTS)
// 1MiB
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
