m-trieu commented on code in PR #34539:
URL: https://github.com/apache/beam/pull/34539#discussion_r2033816500
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/WindmillConnection.java:
##########
@@ -48,17 +49,21 @@ public static Builder builder() {
public abstract String backendWorkerToken();
- public abstract Optional<WindmillServiceAddress> directEndpoint();
+ abstract Optional<WindmillServiceAddress> directEndpoint();
- public abstract CloudWindmillServiceV1Alpha1Stub stub();
+ abstract Supplier<CloudWindmillServiceV1Alpha1Stub> stubFactory();
+
+ public final CloudWindmillServiceV1Alpha1Stub newStub() {
+ return stubFactory().get();
+ }
@AutoValue.Builder
public abstract static class Builder {
abstract Builder setBackendWorkerToken(String backendWorkerToken);
- public abstract Builder setDirectEndpoint(WindmillServiceAddress value);
+ abstract Builder setDirectEndpoint(WindmillServiceAddress value);
- public abstract Builder setStub(CloudWindmillServiceV1Alpha1Stub stub);
+ public abstract Builder
setStubFactory(Supplier<CloudWindmillServiceV1Alpha1Stub> stubFactory);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
