scwhittle commented on code in PR #34539:
URL: https://github.com/apache/beam/pull/34539#discussion_r2037443308
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/ChannelCache.java:
##########
@@ -169,8 +160,16 @@ boolean isEmpty() {
public void appendSummaryHtml(PrintWriter writer) {
synchronized (this) {
if (currentFlowControlSettings != null) {
Review Comment:
how about making resolveFlowControlSettings a private member of this class
so this method and the cache loader can share it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
