m-trieu commented on code in PR #34539:
URL: https://github.com/apache/beam/pull/34539#discussion_r2038369638
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/ChannelCache.java:
##########
@@ -169,8 +160,16 @@ boolean isEmpty() {
public void appendSummaryHtml(PrintWriter writer) {
synchronized (this) {
if (currentFlowControlSettings != null) {
Review Comment:
sgtm, im going to modify the code to remove `WindmillStubFactoryFactory`
after this PR is submitted now that we have the `ChannelCache` that can reload
based on job settings updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
