damccorm commented on code in PR #34539:
URL: https://github.com/apache/beam/pull/34539#discussion_r2044846642
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/ChannelCache.java:
##########
@@ -158,27 +150,34 @@ boolean isEmpty() {
@Override
public void appendSummaryHtml(PrintWriter writer) {
- synchronized (this) {
- if (currentFlowControlSettings != null) {
- writer.format("Current gRPC flow control settings: [%s]",
currentFlowControlSettings);
- } else {
- writer.format(
- "Cloudpath gRPC flow control settings: [%s]",
- WindmillChannels.DEFAULT_CLOUDPATH_FLOW_CONTROL_SETTINGS);
- writer.write("<br>");
- writer.format(
- "Directpath gRPC flow control settings: [%s]",
- WindmillChannels.DEFAULT_DIRECTPATH_FLOW_CONTROL_SETTINGS);
- writer.write("<br>");
- }
- }
+ writer.format(
Review Comment:
Won't this now just write the same string twice if
`currentFlowControlSettings` is not null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
