m-trieu commented on code in PR #34148:
URL: https://github.com/apache/beam/pull/34148#discussion_r2045201717
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/WindmillEndpoints.java:
##########
@@ -70,11 +73,16 @@ public static WindmillEndpoints from(
endpointProto ->
Endpoint.from(endpointProto,
workerMetadataResponseProto.getExternalEndpoint()))
.collect(toImmutableSet());
-
+ // EndpointType endpointType =
Review Comment:
remove
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/WindmillEndpoints.java:
##########
@@ -155,6 +163,15 @@ private static Optional<HostAndPort>
tryParseDirectEndpointIntoIpV6Address(
*/
public abstract ImmutableSet<Endpoint> windmillEndpoints();
+ public abstract EndpointType endpointType();
+
+ // public enum EndpointType {
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
