parveensania commented on code in PR #34148:
URL: https://github.com/apache/beam/pull/34148#discussion_r2085926590
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -243,17 +245,31 @@ private StreamingDataflowWorker(
@Nullable ChannelzServlet channelzServlet = null;
Consumer<PrintWriter> getDataStatusProvider;
Supplier<Long> currentActiveCommitBytesProvider;
-
- if (options.isEnableStreamingEngine() &&
options.getIsWindmillServiceDirectPathEnabled()) {
- // Direct path pipelines.
+ WindmillStreamPool<GetDataStream> getDataStreamPool =
Review Comment:
For Appliance getDataStreamPool is getting used to create getDataClient
which then gets passed to SingleSourceWorkerHarness.
I think the existing split makes sense logically. As direct-SE uses the
FanOutStreamingEngineWorkerHarness and both non-direct SE and Appliance use
SingleSourceWorkerHarness.
LMK if you still think we should change the structure of the if clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
