parveensania commented on code in PR #34148:
URL: https://github.com/apache/beam/pull/34148#discussion_r2085922239
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarness.java:
##########
@@ -424,23 +460,28 @@ private GlobalDataStreamSender getOrCreateGlobalDataSteam(
keyedEndpoint.getValue()));
}
- private WindmillStreamSender createAndStartWindmillStreamSender(Endpoint
endpoint) {
- WindmillStreamSender windmillStreamSender =
- WindmillStreamSender.create(
- WindmillConnection.from(endpoint, this::createWindmillStub),
- GetWorkRequest.newBuilder()
- .setClientId(jobHeader.getClientId())
- .setJobId(jobHeader.getJobId())
- .setProjectId(jobHeader.getProjectId())
- .setWorkerId(jobHeader.getWorkerId())
- .build(),
- GetWorkBudget.noBudget(),
- streamFactory,
- workItemScheduler,
- getDataStream ->
- StreamGetDataClient.create(
- getDataStream, this::getGlobalDataStream,
getDataMetricTracker),
- workCommitterFactory);
+ private WindmillStreamSender createAndStartWindmillStreamSender(
+ Endpoint endpoint, EndpointType enpointType) {
+ WindmillStreamSender windmillStreamSender;
+ windmillStreamSender =
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
