tomstepp commented on code in PR #34669:
URL: https://github.com/apache/beam/pull/34669#discussion_r2050865082
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaCheckpointMark.java:
##########
@@ -35,21 +34,25 @@
*/
@DefaultCoder(AvroCoder.class)
public class KafkaCheckpointMark implements UnboundedSource.CheckpointMark {
+ private static final long OFFSET_DEDUP_PARTITIONS_PER_SPLIT = 1;
private List<PartitionMark> partitions;
@AvroIgnore
- private Optional<KafkaUnboundedReader<?, ?>> reader; // Present when offsets
need to be committed.
+ private KafkaUnboundedReader<?, ?> reader;
+
+ private boolean commitOffsetsInFinalize;
Review Comment:
@Abacn, I am not sure what the Avro stuff, such as AvroIgnore, means here.
Perhaps commitOffsetsInFinalize should have AvroIgnore annotation as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
