Abacn commented on code in PR #34669:
URL: https://github.com/apache/beam/pull/34669#discussion_r2051130949
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java:
##########
@@ -268,7 +268,8 @@ public CheckpointMark getCheckpointMark() {
p.nextOffset,
p.lastWatermark.getMillis()))
.collect(Collectors.toList()),
- source.getSpec().isCommitOffsetsInFinalizeEnabled() ?
Optional.of(this) : Optional.empty());
Review Comment:
iiuc this PR is a preparation for future change, that need the reader for
tasks other than CommitOffsetsInFinalize. Is that correct?
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java:
##########
@@ -268,7 +268,8 @@ public CheckpointMark getCheckpointMark() {
p.nextOffset,
p.lastWatermark.getMillis()))
.collect(Collectors.toList()),
- source.getSpec().isCommitOffsetsInFinalizeEnabled() ?
Optional.of(this) : Optional.empty());
Review Comment:
iiuc this PR is a preparation for future change, that need the reader for
tasks other than CommitOffsetsInFinalize. Is that correct? If so LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
