tomstepp commented on code in PR #34669:
URL: https://github.com/apache/beam/pull/34669#discussion_r2051137053
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java:
##########
@@ -268,7 +268,8 @@ public CheckpointMark getCheckpointMark() {
p.nextOffset,
p.lastWatermark.getMillis()))
.collect(Collectors.toList()),
- source.getSpec().isCommitOffsetsInFinalizeEnabled() ?
Optional.of(this) : Optional.empty());
Review Comment:
I just reverted the change to remove optional to keep the changes simpler.
Instead we pass in reader if offsetBasedDeduplicationSupported as well. This
was a gap in a previously submitted pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
