sarthakbhutani commented on code in PR #34245:
URL: https://github.com/apache/beam/pull/34245#discussion_r2057726505
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -631,6 +631,24 @@ public Read withMaxBufferElementCount(@Nullable Integer
maxBufferElementCount) {
.build();
}
+ /**
+ * Returns a new {@link BigtableIO.Read} that will skip the large rows
while reading. This
+ * function will switch the base BigtableIO.Reader class to using the
+ * BigtableReaderWithExperimentalOptions. If
+ *
+ * <p>Does not modify this object.
+ *
+ * <p>This is incompatible with withMaxBufferElementCount()
+ */
+ public Read withExperimentalSkipLargeRows(@Nullable Boolean skipLargeRows)
{
Review Comment:
@justinuang - will we go with GA for skipLargeRows
or do we want to keep it experiemental - if yes, why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
