sarthakbhutani commented on code in PR #34245:
URL: https://github.com/apache/beam/pull/34245#discussion_r2057756043
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java:
##########
@@ -119,6 +119,27 @@ public void testE2EBigtableRead() {
checkLineageSourceMetric(r, tableId);
}
+ @Test
+ public void testE2EBigtableReadWithSkippingLargeRows() {
+ BigtableOptions.Builder bigtableOptionsBuilder =
+ new
BigtableOptions.Builder().setProjectId(project).setInstanceId(options.getInstanceId());
+
+ final String tableId = "BigtableReadTest";
+ final long numRows = 1000L;
Review Comment:
this doesn't.
the main logic lies in the java-client. Apache beam implementation is only a
wrapper to call that implementation. I couldn't figure out - how to test the
large row skipping in a IT here - it's already being done in the java-client.
it came out in our discussion earlier, that we need a data integrity check
where no data loss should happen.
hence, this is a check for data integrity - that if there isn't a large row,
the feature still works as expected - reading all the rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
