igorbernstein2 commented on code in PR #34245:
URL: https://github.com/apache/beam/pull/34245#discussion_r2060267847
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -174,10 +177,18 @@ public boolean start() throws IOException {
query.filter(Filters.FILTERS.fromProto(rowFilter));
}
try {
- stream =
- client
- .readRowsCallable(new BigtableRowProtoAdapter())
- .call(query, GrpcCallContext.createDefault());
+ if (bigtableReadOptions != null
+ &&
Boolean.TRUE.equals(bigtableReadOptions.getExperimentalSkipLargeRows())) {
+ stream =
+ client
+ .skipLargeRowsCallable(new BigtableRowProtoAdapter())
+ .call(query, GrpcCallContext.createDefault());
+ } else {
+ stream =
+ client
+ .readRowsCallable(new BigtableRowProtoAdapter())
+ .call(query, GrpcCallContext.createDefault());
+ }
Review Comment:
No, I meant keep the unary callable where it is, but resolve unset value in
the settings. ie this logic:
```
bigtableReadOptions != null
&&
Boolean.TRUE.equals(bigtableReadOptions.getExperimentalSkipLargeRows()
```
What unset means should be resolved during pipeline construction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
