tvalentyn commented on a change in pull request #12756:
URL: https://github.com/apache/beam/pull/12756#discussion_r485855090
##########
File path: sdks/python/apache_beam/transforms/stats_test.py
##########
@@ -41,13 +40,15 @@
from apache_beam.transforms.display import DisplayData
from apache_beam.transforms.display_test import DisplayDataItemMatcher
from apache_beam.transforms.stats import ApproximateQuantilesCombineFn
+from apache_beam.transforms.stats import ApproximateUniqueCombineFn
class ApproximateUniqueTest(unittest.TestCase):
- """Unit tests for ApproximateUnique.Globally and ApproximateUnique.PerKey.
- Hash() with Python3 is nondeterministic, so Approximation algorithm generates
- different result each time and sometimes error rate is out of range, so add
- retries for all tests who actually running approximation algorithm."""
+ """Unit tests for ApproximateUnique.Globally, ApproximateUnique.PerKey,
+ and ApproximateUniqueCombineFn.
Review comment:
We can still do Dataflow import with a new dependency, AFAIK we noticed
that Google internal-only tests for Beam on Windows were failing, so we thought
that adding mmh3 would be a concern for all Beam Windows users. I no longer see
failures in Windows precommit tests running on the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
