tvalentyn commented on a change in pull request #12756:
URL: https://github.com/apache/beam/pull/12756#discussion_r485862569
##########
File path: sdks/python/apache_beam/transforms/stats_test.py
##########
@@ -41,13 +40,15 @@
from apache_beam.transforms.display import DisplayData
from apache_beam.transforms.display_test import DisplayDataItemMatcher
from apache_beam.transforms.stats import ApproximateQuantilesCombineFn
+from apache_beam.transforms.stats import ApproximateUniqueCombineFn
class ApproximateUniqueTest(unittest.TestCase):
- """Unit tests for ApproximateUnique.Globally and ApproximateUnique.PerKey.
- Hash() with Python3 is nondeterministic, so Approximation algorithm generates
- different result each time and sometimes error rate is out of range, so add
- retries for all tests who actually running approximation algorithm."""
+ """Unit tests for ApproximateUnique.Globally, ApproximateUnique.PerKey,
+ and ApproximateUniqueCombineFn.
Review comment:
py3 hash is non-deterministic, see BEAM-10824 and internal issue
b/166646014 which has a bit more details.
We should not be using py3 hash function, and I support this change. Current
change supports both md5 and mmh3, but we have a remanining question whether
mmh3 should be a default dep (better performance than md5), but extra
dependency, or optional (default to md5, give a warning recommendation to
install mmh3).
HLL is not available for Beam Python yet, is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
