shunping commented on code in PR #35089:
URL: https://github.com/apache/beam/pull/35089#discussion_r2115134295
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1648,6 +1648,10 @@ keysPerBundle:
continue
}
holdsInBundle[e.holdTimestamp]++
+ if e.timestamp > watermark {
Review Comment:
Yes. From what I see, after the timer is set on the SDK side, it becomes one
of the pending elements in the heap. If the input data is not arriving fast
enough (watermark is growing slowly), at some point, the timer element is the
only element in the heap. Even though the watermark is smaller than the timer
firing timestamp, the runner still packs the timer element to the bundle and
sends it over to the sdk.
Something I need to confirm with you is that the SDK seems to immediately
run the timer callback as it sees the timer element. Is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
