lostluck commented on code in PR #35089:
URL: https://github.com/apache/beam/pull/35089#discussion_r2116307659
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1648,6 +1648,10 @@ keysPerBundle:
continue
}
holdsInBundle[e.holdTimestamp]++
+ if e.timestamp > watermark {
Review Comment:
If the Java prism suite continues to pass, I have no objections. I think
you're right about the premature firing given the "set timer in the far future"
experiment.
This might have slipped in when I split the eventTime bundle building method
through the different kinds....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
